Skip to content

Support Plaster 1.1.0 #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daviwil opened this issue May 22, 2017 · 7 comments
Closed

Support Plaster 1.1.0 #461

daviwil opened this issue May 22, 2017 · 7 comments
Labels
Issue-Bug A bug to squash.

Comments

@daviwil
Copy link
Contributor

daviwil commented May 22, 2017

Plaster 1.1.0 hasn't been released yet, but anyone who tries to use Plaster from GitHub with the PowerShell extension will see errors like this:

image

We need to support the changes that have been made to Plaster so that the language server doesn't crash.

Thanks @bgelens!

@daviwil daviwil added this to the 1.3.0 milestone May 22, 2017
@daviwil daviwil added the Issue-Bug A bug to squash. label May 22, 2017
@rkeithhill
Copy link
Contributor

rkeithhill commented May 22, 2017

I haven't done enough testing on PS Core 6 Beta on .NET Core 2 either. I can test on Ubuntu easily enough. Can we configure an AppVeyor build for Ubuntu?

@daviwil
Copy link
Contributor Author

daviwil commented May 22, 2017

We have to use Travis CI for Linux and macOS. I had started looking into it in the past but haven't got anything working yet. It'd be good to find a replicable Travis CI setup for all these projects!

@rkeithhill
Copy link
Contributor

Yeah, having cross platform Pester testing would be nice.

@PowerSchill
Copy link
Contributor

The goal would be to add Linux and macOS testing to the Plaster repo or here?

@daviwil
Copy link
Contributor Author

daviwil commented May 23, 2017

Both! We'd test PSES here and Plaster at the Plaster repo.

@TylerLeonhardt
Copy link
Member

@daviwil looks like we're beyond this issue as Plaster 1.1.3 ships with the vscode extension. Is this about something else?

@daviwil
Copy link
Contributor Author

daviwil commented Dec 7, 2017

Nope, just didn't remember to close it.

@daviwil daviwil closed this as completed Dec 7, 2017
TylerLeonhardt pushed a commit to TylerLeonhardt/PowerShellEditorServices that referenced this issue Feb 26, 2019
…status

Show formatting status in status bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

No branches or pull requests

4 participants