Rework log builder to support logging to files #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Looks great--when we merge this change in let's also make sure that we make any necessary changes to our troubleshooting guide and our issue templates |
rjmholt
approved these changes
Oct 14, 2019
4 tasks
|
Merged to get PowerShell/vscode-powershell#2238 building |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the title says it all... 3 cheers for the .NET builder pattern.
Here's what our logs look like.
EditorServices.log
Note, we still need this issue to be resolved to get logs of the payload... but we can get the payloads... just not in the file logs... the user can add:
in their settings which will give them an Output window in vscode that contains the payloads that is compliant with the lsp inspector.
It's an extra process.. but it's the best we've got so far. It will get better.
Note this also updates the
usings forMediatrdue to an Omnisharp change.