Fix duplicate diagnostics caused by DidChange handler #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
changed the title
rjmholt
reviewed
Oct 31, 2019
src/PowerShellEditorServices/Services/TextDocument/Handlers/TextDocumentHandler.cs
Show resolved
Hide resolved
| changedFile.ApplyChange( | ||
| GetFileChangeDetails( | ||
| textChange.Range, | ||
| textChange.Text)); | ||
|
|
||
| changedFiles.Add(changedFile); |
| @@ -145,6 +145,43 @@ public async Task CanReceiveDiagnosticsFromFileOpen() | |||
| Assert.Equal("PSUseDeclaredVarsMoreThanAssignments", diagnostic.Code); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task CanReceiveDiagnosticsFromFileChanged() | |||
rjmholt
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that duplicate diagnostics were being sent to vscode because we iterated through the ContentChanges and asked for diagnostics in that loop, even though, the changes pertained to the same file.
You can see the bug if you type really fast or use like the
##comment generator and stuff like that because it will include multiple ContentChanges to the same file in 1 textDocument/DidChange event.This properly runs diagnostics after all code changes are applied.
Discovered this originally in #1078 (which has a similar change in it as well... thought it might affect us today and sure enough, it did!)
comes with a test too!