Run one invocation per SetBreakpoints request #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously for every SetBreakpoints request we would invoke ExecuteCommandAsync once for every single breakpoint. This change reduces that to a single call per request.
|
This will get even better when we move to use the APIs in 7. |
|
This so far appears to have fixed PowerShell/vscode-powershell#2319 for me. |
rjmholt
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PowerShell/vscode-powershell#2319
Previously for every
SetBreakpointsrequest we would invokeExecuteCommandAsynconce for every single breakpoint. This change reduces that to a single call per request.Before this change, if I followed the repro steps for PowerShell/vscode-powershell#2319, setting 10 breakpoints in File2 and File3, I couldn't even get it to launch once. With this change I can consistently launch every time.
There's definitely some race conditions in how runspace handles are queued, and the way this request handler was set up was really pushing that to it's limits. Those race conditions still need to be fixed, but this should help significantly in the mean time.