Simplify logic of determining Reference definition #1139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes PowerShell/vscode-powershell#2374
Before, I had the logic backwards and the CodeLens would only show 1 reference (the reference definition!).
After, now we only check file path and line number. Simpler logic.
I added a TODO to think about what would happen if we find two of the same named function definitions:
fileA
fileB
The references will probably show up... but I think there's not much we can do since the symbol reference doesn't seem to give us anything on whether it's a definition or not which is really a shame.