Skip to content

Add Distribution Channel #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 14, 2020
Merged

Add Distribution Channel #1158

merged 9 commits into from
Jan 14, 2020

Conversation

SydneyhSmith
Copy link
Collaborator

Sets the distribution channel to PSES so starts can be distinguished in PS7+ telemetry

@SydneyhSmith SydneyhSmith requested a review from rjmholt as a code owner January 14, 2020 16:16
@TylerLeonhardt
Copy link
Member

You made a method, but that method needs still be called. Call SetDistributionChannel() inside of the constructor of the class or just put the Environment. line inside the constructor since it's just one line.

If you go with the first option, make sure to set the method to static.

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Jan 14, 2020 •
edited
Loading

Put it here above this line:

PowerShellEditorServices/src/PowerShellEditorServices.Hosting/Commands/StartEditorServicesCommand.cs

Line 41 in 9c475ff

_disposableResources = new List<IDisposable>();

TylerLeonhardt
TylerLeonhardt approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rjmholt
rjmholt approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a non-blocking comment, but LGTM

@SydneyhSmith SydneyhSmith mentioned this pull request Jan 14, 2020
Merged
@TylerLeonhardt
Copy link
Member

once all the CI passes - I'll merge

@TylerLeonhardt TylerLeonhardt merged commit 32ef020 into PowerShell:master Jan 14, 2020
TylerLeonhardt pushed a commit that referenced this pull request Jan 14, 2020
@SydneyhSmith @TylerLeonhardt
[Ignore] Update CHANGELOG.md to include PR #1158 (#1159)
6041b33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

@rjmholt rjmholt rjmholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SydneyhSmith @TylerLeonhardt @rjmholt