Skip to content

Use Assembly.LoadFile in WinPS #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2020
Merged

Use Assembly.LoadFile in WinPS #1227

merged 3 commits into from
Mar 11, 2020

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Mar 10, 2020

Switch over to using Assembly.LoadFile() instead of Assembly.LoadFrom() to load dependency assemblies in WinPS to avoid clobbering module dependencies.

Fixes PowerShell/vscode-powershell#2397
Fixes PowerShell/vscode-powershell#2545

@rjmholt rjmholt marked this pull request as ready for review March 11, 2020 19:01
TylerLeonhardt
TylerLeonhardt approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with this if we wanna give it a go

@rjmholt rjmholt merged commit 5b7af3f into PowerShell:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rjmholt @TylerLeonhardt