Add cancellation for textDocument/completion, textDocument/codeAction, textDocument/folding
#1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/PowerShellEditorServices/Services/TextDocument/Handlers/FoldingRangeHandler.cs
Outdated
Show resolved
Hide resolved
rjmholt
approved these changes
Mar 20, 2020
rjmholt
approved these changes
Mar 24, 2020
src/PowerShellEditorServices/Services/TextDocument/Handlers/CodeActionHandler.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/TextDocument/Handlers/CompletionHandler.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/TextDocument/Handlers/CompletionHandler.cs
Outdated
Show resolved
Hide resolved
|
Issues
======
+ Solved 5
- Added 4
Complexity increasing per file
==============================
- src/PowerShellEditorServices/Services/TextDocument/Handlers/CodeActionHandler.cs 1
- src/PowerShellEditorServices/Services/TextDocument/Handlers/FoldingRangeHandler.cs 1
Clones removed
==============
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/DocumentSymbolHandler.cs -1
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/HoverHandler.cs -1
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/DefinitionHandler.cs -1
+ src/PowerShellEditorServices/Services/Workspace/Handlers/WorkspaceSymbolsHandler.cs -1
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/CompletionHandler.cs -1
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/FoldingRangeHandler.cs -1
See the complete overview on Codacy |
TylerLeonhardt
commented
Mar 24, 2020
| @@ -30,16 +30,22 @@ public FoldingRangeHandler(ILoggerFactory factory, ConfigurationService configur | |||
| _configurationService = configurationService; | |||
| _workspaceService = workspaceService; | |||
| } | |||
| public TextDocumentRegistrationOptions GetRegistrationOptions() | |||
|
|
|||
| public FoldingRangeRegistrationOptions GetRegistrationOptions() | |||
There was a problem hiding this comment.
TylerLeonhardt
commented
Mar 24, 2020
| @@ -37,9 +38,17 @@ internal class DocumentFormattingHandlers : IDocumentFormattingHandler, IDocumen | |||
| _workspaceService = workspaceService; | |||
| } | |||
|
|
|||
| public TextDocumentRegistrationOptions GetRegistrationOptions() | |||
| public DocumentFormattingRegistrationOptions GetRegistrationOptions() | |||
There was a problem hiding this comment.
TylerLeonhardt
commented
Mar 24, 2020
| }; | ||
| } | ||
|
|
||
| DocumentRangeFormattingRegistrationOptions IRegistration<DocumentRangeFormattingRegistrationOptions>.GetRegistrationOptions() |
There was a problem hiding this comment.
TylerLeonhardt
commented
Mar 24, 2020
| _logger.LogInformation("highlight handler loaded"); | ||
| } | ||
|
|
||
| public TextDocumentRegistrationOptions GetRegistrationOptions() | ||
| public DocumentHighlightRegistrationOptions GetRegistrationOptions() |
There was a problem hiding this comment.
|
apparently prereleases are also signed so we can go with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PowerShell/vscode-powershell#2556
possibly fixes PowerShell/vscode-powershell#2518
possibly fixes PowerShell/vscode-powershell#2522
Probably should wait til a stable release of Omnisharp but they've fixed cancellation and this does feel faster in @adamdriscoll's ps1 talked about here: PowerShell/vscode-powershell#2556 (comment)
when testing in that ps1 for a bit I received this number of requests that wanted to be cancelled:
This PR could cancel 14 + 7 + 3 = 24 out of 29 requests (best case)