Refactor GetCommandSynopsisAsync method make sure cmdlets with module prefixes work #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
commented
Mar 26, 2020
| @@ -76,36 +76,36 @@ static CommandHelpers() | |||
| CommandInfo commandInfo, | |||
| PowerShellContextService powerShellContext) | |||
| { | |||
| Validate.IsNotNull(nameof(commandInfo), commandInfo); | |||
There was a problem hiding this comment.
added this since all references checked commandInfo != null already
TylerLeonhardt
force-pushed
the
fix-commands-with-prefix
branch
from
e0813e0 to
774c241
Compare
|
Complexity decreasing per file
==============================
+ src/PowerShellEditorServices/Services/PowerShellContext/Utilities/CommandHelpers.cs -1
See the complete overview on Codacy |
rjmholt
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1242
Fixes PowerShell/vscode-powershell#2584
This method needed a good refactor... The main change here is:
instead of
because
commandInfo.ToString()gives you duplicate Prefixes... I'll link that PowerShell/PowerShell issue here when the original filer opens it.