-
Notifications
You must be signed in to change notification settings - Fork 234
No warning about module being imported #1258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No warning about module being imported #1258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ LGTM! two very optional minor suggestions
src/PowerShellEditorServices/Services/PowerShellContext/Session/PSReadLinePromptContext.cs
Outdated
Show resolved
Hide resolved
Complexity increasing per file
==============================
- src/PowerShellEditorServices/Services/PowerShellContext/PowerShellContextService.cs 1
- src/PowerShellEditorServices/Utility/PSCommandExtensions.cs 1
See the complete overview on Codacy |
Verified this still works on Windows PowerShell. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
fixes PowerShell/vscode-powershell#2626
This no longer exposes the cmdlets and instead creates a
CmdletInfo
object with the implementing type.Unfortunately, we have to work around 2 PowerShell issues:
PowerShell/PowerShell#12295
PowerShell/PowerShell#12297