Skip to content

No warning about module being imported #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TylerLeonhardt
Copy link
Member

fixes PowerShell/vscode-powershell#2626

This no longer exposes the cmdlets and instead creates a CmdletInfo object with the implementing type.

Unfortunately, we have to work around 2 PowerShell issues:
PowerShell/PowerShell#12295
PowerShell/PowerShell#12297

@TylerLeonhardt TylerLeonhardt changed the title No warning about module No warning about module being imported Apr 10, 2020
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ LGTM! two very optional minor suggestions

@TylerLeonhardt
Copy link
Member Author

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/PowerShellEditorServices/Services/PowerShellContext/PowerShellContextService.cs  1
- src/PowerShellEditorServices/Utility/PSCommandExtensions.cs  1
         

See the complete overview on Codacy

@TylerLeonhardt
Copy link
Member Author

Verified this still works on Windows PowerShell.

Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unapproved verbs warning in latest preview
3 participants