Skip to content

Fix interpolation in Log points, switch to double quotes #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rkeithhill
Copy link
Contributor

@rkeithhill rkeithhill commented Apr 22, 2020

Fix PowerShell/vscode-powershell#2654

When this works you can do some fancy stuff like timing loops:

image

This uses messages:

Init loop var: $($global:prevTS = Get-Date; $prevTS)
Loop time: $($currTS = Get-Date; ($currTS - $prevTS).TotalMilliseconds; $global:prevTS = $currTS) ms

@rkeithhill
Copy link
Contributor Author

I don't think the build errors are associated with this change:

  X PowerShellEditorServices.Test.E2E.LanguageServerProtocolMessageTests.CanReceiveDiagnosticsFromFileChanged [3s 18ms]
  Error Message:
   The collection was expected to contain a single element, but it contained more than one element.
  Stack Trace:
     at PowerShellEditorServices.Test.E2E.LanguageServerProtocolMessageTests.CanReceiveDiagnosticsFromFileChanged() in D:\a\1\s\test\PowerShellEditorServices.Test.E2E\LanguageServerProtocolMessageTests.cs:line 190
--- End of stack trace from previous location where exception was thrown ---

@TylerLeonhardt
Copy link
Member

It's not you

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt
Copy link
Member

yay logpoints! 🎉

@TylerLeonhardt TylerLeonhardt merged commit 6567d5c into PowerShell:master Apr 23, 2020
@rkeithhill rkeithhill deleted the rkeithhill/fix-logpoints-interpolation branch April 23, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log points don't support interpolation
3 participants