Move tests to PS7 and PS7.1 and fix IsNetCore check #1318
Conversation
| completionResults.Completions[0].CompletionType | ||
| ); | ||
|
|
||
| Assert.NotNull(completionResults.Completions[0].ToolTipText); |
There was a problem hiding this comment.
Note, the signature of Get-Random changed so I'm asserting on less things but I think it's fine.
ghost
added
|
|
||
| task TestServerPS71 { |
There was a problem hiding this comment.
This is nice -- should help us ensure forward compat
|
|
||
| namespace Microsoft.PowerShell.EditorServices.Test.Utility | ||
| { | ||
| public class VersionUtilsTests |
|
I had to remove the global.json since we use different SDKs in different places... not sure if there's a way to configure it correctly... |
…t/PowerShellEditorServices into move-tests-to-ps7-and-ps71
| @@ -303,10 +320,6 @@ task LayoutModule -After Build { | |||
| # Copy Third Party Notices.txt to module folder | |||
| Copy-Item -Force -Path "$PSScriptRoot\Third Party Notices.txt" -Destination $psesOutputPath | |||
|
|
|||
| # Copy UnixConsoleEcho native libraries | |||
| Copy-Item -Path "$script:PsesOutput/runtimes/osx-64/native/*" -Destination $psesDepsPath -Force | |||
| Copy-Item -Path "$script:PsesOutput/runtimes/linux-64/native/*" -Destination $psesDepsPath -Force | |||
There was a problem hiding this comment.
this doesn't seem to be needed anymore... which is kinda odd to me... but moving to a newer SDK seems to not generate these folders anymore.
There was a problem hiding this comment.
I've had errors about those folders being missing since they were added tbh. I assumed they were important to CI but I've just been commenting them out.
If the UnixConsoleEcho dlls still end up where they need to be then 🤷 probably remove it
|
hmm what happened to Codacy? |
PowerShellEditorServices.build.ps1
Outdated
| '-Version' | ||
| $Version |
There was a problem hiding this comment.
This is arguably clearer as an array like @('-Version', $Version) so it's obvious that you're using array splatting
Fixes #1317
Fix
IsNetCorelogic, add a test for it that failed before the code change.Also, now our tests run for PS7 and PS7.1.
I've removed PS6 as a target because: