Remove "All Rights Reserved" from copyright notices #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Microsoft policy at: https://docs.opensource.microsoft.com/content/releasing/copyright-headers.html All copyright notices no longer include "All Rights Reserved" and the comment style has been updated to be consistent with policy.
andyleejordan
force-pushed
the
andschwa/copyright
branch
from
ad30829 to
f795e6e
Compare
andyleejordan
force-pushed
the
andschwa/copyright
branch
from
f795e6e to
2449543
Compare
|
@rjmholt We should consider adding an automated check for this (and replacing some of our tools/scripts). |
|
I checked with |
andyleejordan
commented
Apr 29, 2021
| @@ -25,7 +21,7 @@ function Add-CopyrightHeaders($basePath) | |||
| if ($fileContent.StartsWith($copyrightHeaderString) -eq $false) | |||
| { | |||
| # Add the copyright header to the file | |||
| Set-Content $sourceFile.FullName ($copyrightHeaderString + "`r`n`r`n" + $fileContent) | |||
| Set-Content $sourceFile.FullName ($copyrightHeaderString + [Environment]::NewLine + [Environment]::NewLine + $fileContent) | |||
There was a problem hiding this comment.
Slightly fixed up this script, but it also removes the BOM and adds an empty line to the end of files. We should replace this with existing tooling if available.
rjmholt
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Microsoft policy at:
https://docs.opensource.microsoft.com/content/releasing/copyright-headers.html
All copyright notices no longer include "All Rights Reserved" and the comment style has been updated to be consistent with policy.
Resolves #1465
Also double-checked that all
*.csand*.ps1files have a copyright notice.