Add more logging and internal documentation #1474
Conversation
src/PowerShellEditorServices/Services/PowerShellContext/PowerShellContextService.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices.Hosting/Internal/EditorServicesRunner.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Server/PsesServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
As opposed to `PowerShellEditorServices.Hosting`. Same namespace, different assembly.
andyleejordan
force-pushed
the
andschwa/comments
branch
from
169e227 to
6728a90
Compare
| /// </summary> | ||
| /// <remarks> | ||
| /// The logical stack of the program is: |
There was a problem hiding this comment.
@rjmholt Did I get this right?
There was a problem hiding this comment.
Yeah I think that looks right
There was a problem hiding this comment.
Thanks! This was super useful (to me) to work through and document.
andyleejordan
changed the title
| /// </summary> | ||
| /// <remarks> | ||
| /// The logical stack of the program is: |
There was a problem hiding this comment.
Yeah I think that looks right
| /// This is a strange class that is generally <c>null</c> or otherwise just has a single path | ||
| /// set. It is eventually parsed one-by-one when setting up the PowerShell runspace. |
There was a problem hiding this comment.
This class is used for configuring profile path values, which are set by the client. Different clients conceptually implement different hosts (so VSCode implements a different host to vim or IntelliJ), so they need different profile paths. This is how they configure that.
| provider.GetService<OmniSharp.Extensions.LanguageServer.Protocol.Server.ILanguageServerFacade>(), | ||
| hostStartupInfo)) | ||
| .AddSingleton<TemplateService>() | ||
| .AddSingleton<TemplateService>() // TODO: What's the difference between this and the TemplateHandler? |
There was a problem hiding this comment.
Handlers handle requests from the LSP client, like ASP.NET controllers.
Services internally manage some conceptual area, and generally implement the business logic behind handlers.
andyleejordan
force-pushed
the
andschwa/comments
branch
2 times, most recently
from
eb3769c to
dab4e3c
Compare
Also change handled exceptions to warning instead of error.
andyleejordan
force-pushed
the
andschwa/comments
branch
from
dab4e3c to
43f5e1b
Compare
andyleejordan
added
Ignore
Just writing up what I've learned and odd stuff I've spotted while reading through the code. Also added at least a bit more logging to help debug PowerShell/vscode-powershell#3306.