Skip to content

Work around dotnet publish bug #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Work around dotnet publish bug #1494

merged 3 commits into from
Jun 14, 2021

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Jun 4, 2021

@andyleejordan andyleejordan requested a review from rjmholt June 4, 2021 03:19
@andyleejordan
Copy link
Member Author

I kinda think I've hit the same issue as someone else hit with msbuild (which if I remember correctly is what dotnet became a port of): dotnet/standard#1334

@andyleejordan
Copy link
Member Author

I also tried playing around with the various options like --self-contained, since this is a library and we moved from .NET 2.1 to 3.1+ and that behavior changed, but dotnet publish still never included netstandard.dll once the CLI was on 6.0.

@andyleejordan
Copy link
Member Author

Linking regression report upstream: dotnet/sdk#18101

@andyleejordan andyleejordan marked this pull request as draft June 5, 2021 00:21
@andyleejordan andyleejordan marked this pull request as ready for review June 14, 2021 17:00
@andyleejordan andyleejordan merged commit 6e3365b into master Jun 14, 2021
@andyleejordan andyleejordan deleted the andschwa/build-fix branch June 14, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Load Terminal
2 participants