Skip to content

Update README.md #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2021
Merged

Update README.md #1519

merged 2 commits into from
Jul 12, 2021

Conversation

vladdoster
Copy link
Contributor

  • correct spelling
  • correct grammar
  • reduce verbiage
  • correct article agreement
  • add punctuation

@vladdoster
(docs) update README.md
d166d89 
- correct spelling
- correct grammar
- reduce verbiage
- correct article agreement
- add punctuation
@vladdoster vladdoster requested a review from rjmholt as a code owner July 5, 2021 15:24
rjmholt
rjmholt approved these changes Jul 6, 2021
View reviewed changes
@andyleejordan @rjmholt
Update README.md
57f7d9f 
Co-authored-by: Robert Holt <[email protected]>
@andyleejordan andyleejordan enabled auto-merge (squash) July 6, 2021 18:41
@vladdoster
Copy link
Contributor Author

@rjmholt Thank you for the approval. Is there something I need to do to get the CodeQL and CSharp CI jobs to get reported?

@andyleejordan
Copy link
Member

@rjmholt Thank you for the approval. Is there something I need to do to get the CodeQL and CSharp CI jobs to get reported?

Heh, no, we just needed to not require those as they don't run on doc updates.

@vladdoster
Copy link
Contributor Author

@andschwa Is auto-merge stuck or am I naive about how it works? Maybe it is waiting for a release event and then it will be merged?

@andyleejordan andyleejordan disabled auto-merge July 12, 2021 16:38
@andyleejordan andyleejordan merged commit 97a663f into PowerShell:master Jul 12, 2021
@andyleejordan
Copy link
Member

Not naive, it was just stuck for some reason.

@andyleejordan andyleejordan changed the title (docs) update README.md Update README.md Jul 13, 2021
@andyleejordan andyleejordan added Area-Documentation Issue-Enhancement A feature request (enhancement). labels Jul 13, 2021
@vladdoster vladdoster deleted the patch-1 branch July 14, 2021 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmholt rjmholt rjmholt approved these changes

Assignees
No one assigned
Labels
Area-Documentation Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladdoster @andyleejordan @rjmholt