Automate entire release process #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
added
Issue-Enhancement
andyleejordan
force-pushed
the
andschwa/automated-pipeline
branch
from
c35389b to
bfef3e8
Compare
|
I've temporarily restored the |
andyleejordan
force-pushed
the
andschwa/automated-pipeline
branch
from
bfef3e8 to
a590493
Compare
|
Yay! The release it worked. @rjmholt check it: https://github.com/PowerShell/PowerShellEditorServices/releases/tag/untagged-9fb7e73f0f1ec8c30383 |
|
Oops, I have to fix something. |
This splits the release into three stages: build, sign, and publish. The last stage requires a manual approval on its deployment job's associated environment. When approved, it creates a draft GitHub release using our ReleaseTools module and securely uploads the artifacts directly from the build agent, thus taking developer machines out of the release process.
So we have fewer folders.
andyleejordan
force-pushed
the
andschwa/automated-pipeline
branch
2 times, most recently
from
6649bc5 to
4c02284
Compare
|
Just double-checking those new changes didn't break the release build... |
Also move the creation of said artifacts into Azure DevOps templates themselves, instead of in the build system. Finally, download only the signed pipeline artifacts in the deployment, which by default downloads all artifacts.
It leads to bugs I cannot solve.
- Use proper `parameters` syntax - Use cleaner indentation - Add decent display names - Remove setting build name for non-PR builds - Remove unused NUnit test results
andyleejordan
force-pushed
the
andschwa/automated-pipeline
branch
from
4c02284 to
85eae62
Compare
|
Ok, that's it! It all works. |
rjmholt
approved these changes
Jul 22, 2021
| jobs: | ||
| - job: Build | ||
| pool: | ||
| vmImage: vs2017-win2016 |
There was a problem hiding this comment.
I could have sworn there was a newer one than this
There was a problem hiding this comment.
There is, actually. Another time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up the final parts necessary for the Azure DevOps release pipeline to create a (draft) GitHub Release with the built assets directly uploaded from the pipeline itself. This eliminates any developer machine touching the bits between build, sign, and release. There is a manual approval step in the deployment such that the draft release is not created until a Microsoft maintainer approves it. It also includes a few cleanups (such as moving from "build artifacts" to "pipeline artifacts"). It was tested up to the point that the GitHub API complained the release branch didn't exist, which since I wasn't testing off a release branch, was accurate.