Fix creation of InitialSessionState to use CreateDefault2()
#1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
force-pushed
the
andschwa/createdefault2
branch
from
a1449d2 to
68fe561
Compare
rjmholt
approved these changes
Aug 18, 2021
We erroneously changed our code to use `CreateDefault()` instead of `CreateDefault2()`. There existed old but defunct code for testing the use of `CreateDefault()` instead, but it was never intentionally moved into production. The latter function loads only `Microsoft.PowerShell.Core`, leaving us to load the exact modules we intend to load ourselves, which is the safer behavior (and the previous behavior).
andyleejordan
force-pushed
the
andschwa/createdefault2
branch
from
68fe561 to
c014631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We erroneously changed our code to use
CreateDefaultinstead ofCreateDefault2. There existed old but defunct code for testing the use ofCreateDefaultinstead, but it was never intentionally moved into production. The latter function loads onlyMicrosoft.PowerShell.Core, leaving us to load the exact modules we intend to load ourselves, which is the safer behavior (and the previous behavior).