Skip to content

Install a single dotnet SDK #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2021
Merged

Install a single dotnet SDK #1619

merged 1 commit into from
Nov 5, 2021

Conversation

andyleejordan
Copy link
Member

But also install all the necessary runtimes.

Replaces #1616.

@andyleejordan andyleejordan changed the title Install only one dotnet SDK Install a single dotnet SDK Nov 4, 2021
@andyleejordan andyleejordan force-pushed the andschwa/one-sdk branch 2 times, most recently from b3131c0 to 3996ba8 Compare November 4, 2021 22:42
@andyleejordan
Copy link
Member Author 

> git clean -fdx
...
> Invoke-Build SetupDotNet
...
> ls ./.dotnet/sdk
6.0.100-rc.2.21505.57

@andyleejordan
Install only one dotnet SDK
13df179 
But also install all the necessary runtimes.
@andyleejordan andyleejordan marked this pull request as ready for review November 4, 2021 23:15
@andyleejordan andyleejordan enabled auto-merge (squash) November 4, 2021 23:37
daxian-dbw
daxian-dbw approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JustinGrote
Copy link
Collaborator

LGTM, looks like it shaves a minute or two off most builds.

@andyleejordan andyleejordan merged commit 78cb9ad into master Nov 5, 2021
@andyleejordan andyleejordan deleted the andschwa/one-sdk branch November 5, 2021 16:34
@andyleejordan andyleejordan added Ignore Exclude from the changelog. Area-Build & Release Issue-Enhancement A feature request (enhancement). and removed Ignore Exclude from the changelog. labels Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@JustinGrote JustinGrote JustinGrote approved these changes

Assignees
No one assigned
Labels
Area-Build & Release Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyleejordan @JustinGrote @daxian-dbw