Split and clean up LanguageServiceTests.cs
#1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
changed the title
LanguageServiceTests.csLanguageServiceTests.cs
This was broken because in an ancient rewrite, it wasn't caught that this test expected the workspace path to be set to the "References" folder. Inspect the test's source at commit 449cc21 to confirm.
… tests This had been erroneously removed in commit 32451c0 leading to dead code, but were able to be resurrected without issue.
andyleejordan
force-pushed
the
andschwa/language-tests
branch
from
4e8441f to
e72a796
Compare
|
@SeeminglyScience @rjmholt Please look at that last commit carefully: I've resurrected really old code to support aliases when finding references, and re-enabled the corresponding test. |
andyleejordan
force-pushed
the
andschwa/language-tests
branch
from
d49d8f4 to
e72a796
Compare
I've actually removed that from this PR and have made it a new PR #1656 after cleaning it up. |
ghost
added
the
|
Thanks @daxian-dbw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it now covers the symbols service and completions handler separately. Resolves #1445.