Skip to content

Re-enable line breakpoints for untitled scripts #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

andyleejordan
Copy link
Member

We managed to make the previous hack work while continuing to support
passing the users' arguments. As there was demand for this feature to
continue working, despite being a hack, we're keeping it.

We managed to make the previous hack work while continuing to support
passing the users' arguments. As there was demand for this feature to
continue working, despite being a hack, we're keeping it.
@andyleejordan andyleejordan force-pushed the andschwa/untitled-scripts branch from 5bb818b to 30080f3 Compare February 23, 2022 19:14
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Ty for fully detailing the jank in the comments so it's easier to tell why it is the way it is ❤️

Copy link
Collaborator

@JustinGrote JustinGrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LHTM (looks hacky to me), thanks for taking the time to doc as already mentioned.

@andyleejordan andyleejordan merged commit e2827a1 into master Feb 23, 2022
@andyleejordan andyleejordan deleted the andschwa/untitled-scripts branch February 23, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Debugging Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants