Fix editor commands to interrupt current prompt #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactored it slightly to accept the existing `cancellationToken` send to the handler, and removed an unused logger service.
andyleejordan
commented
Feb 23, 2022
| request.Name, | ||
| editorContext).ConfigureAwait(false); | ||
|
|
||
| return await Unit.Task.ConfigureAwait(false); |
There was a problem hiding this comment.
No idea why this was the old return type. Almost everything else using the same API returns Unit.Value (which seems the right thing to return).
There was a problem hiding this comment.
Ah, clarification on that "almost" it's that async Task<Unit> with an await needs to return Unit.Value, and if it's not async then it's a Unit.Task that needs to be returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactored it slightly to accept the existing
cancellationTokensend to the handler, and removed an unused logger service. This fixes PowerShell/vscode-powershell#3691.