Fix formatting handlers and PSScriptAnalyzer loading #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we don't return formatting for an old document.
Similar to PSReadLine, we need to use only our bundled version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we return
nullper the LSP specification if the formatting request was canceled (such as will happen if the document is modified since the request was sent), and we only load our bundled PSScriptAnalzyer module. Similar to PSReadLine, we should not support loading an arbitrary version of the module, as that leads to difficult to fix bugs and complicates the code.Should fix PowerShell/vscode-powershell#3928 and PowerShell/vscode-powershell#3926.