Skip to content

Don't cancel on disposal of CancellationScope #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

andyleejordan
Copy link
Member

This eliminates an extra cancellation on tokens that are getting disposed.

@andyleejordan andyleejordan added the Ignore Exclude from the changelog. label Apr 27, 2022
@andyleejordan andyleejordan requested a review from a team April 27, 2022 18:18
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan enabled auto-merge (squash) April 27, 2022 18:21
@andyleejordan andyleejordan disabled auto-merge April 27, 2022 18:21
@andyleejordan andyleejordan enabled auto-merge (squash) April 27, 2022 18:21
@andyleejordan andyleejordan merged commit 9926944 into master Apr 27, 2022
@andyleejordan andyleejordan deleted the andschwa/double-disposal branch April 27, 2022 18:39
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Engine and removed Ignore Exclude from the changelog. labels Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Engine Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants