-
Notifications
You must be signed in to change notification settings - Fork 234
Bring back WriteWithPrompt()
#1781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back WriteWithPrompt()
#1781
Conversation
We were running into a situation where we'd print the prompt on the same line that we had previously printed it. This was especially noticable when stepping through the debugger. This change ensures that we always write a new line if that situation occurs.
Do we just want to bring |
Yeah probably. I wonder why that works for you if you're not setting cursor left to zero somewhere... That said I don't know if we want to reuse the prompt even if we have the option. That might need to be opt in otherwise it may confuse some folks. But we'd need to skip writing the prompt as well for that to work I'd think |
That work as "expected" now? |
WriteWithPrompt()
Yep it works. Would be interesting to see if we can revert this and find a way to not write the prompt when we don't need to as an option though. I like the idea. Probably for another time though |
We were running into a situation where we'd print the prompt on the same line that we had previously printed it. This was especially noticable when stepping through the debugger.
This change ensures that we always write a new line if that situation occurs.
Examples: