Skip to content

Improve $PROFILE variable and profile loading test #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

andyleejordan
Copy link
Member

Now we actually check that it is well-formed.

@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Test labels Jun 16, 2022
@andyleejordan andyleejordan requested a review from a team June 16, 2022 18:54
@andyleejordan andyleejordan mentioned this pull request Jun 16, 2022
@andyleejordan andyleejordan force-pushed the andschwa/profile-properties branch from b4330f4 to 9a4a5a5 Compare June 16, 2022 19:17
@andyleejordan andyleejordan enabled auto-merge (squash) June 16, 2022 19:18
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit 2202e8c into master Jun 16, 2022
@andyleejordan andyleejordan deleted the andschwa/profile-properties branch June 16, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Test Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants