Improve CI stability #1848
Merged
Improve CI stability #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
commented
Jul 1, 2022
| @@ -109,6 +111,7 @@ public async Task CompletesVariableInFile() | |||
| public async Task CompletesAttributeValue() | |||
| { | |||
| (_, IEnumerable<CompletionItem> results) = await GetCompletionResultsAsync(CompleteAttributeValue.SourceDetails).ConfigureAwait(true); | |||
| Assert.Equal(3, results.Count()); | |||
There was a problem hiding this comment.
If this fails in flaky test, we'll know that it's not a sorting issue (which it shouldn't be, because we already sort it, but this has been hell to figure out).
SeeminglyScience
approved these changes
Jul 1, 2022
andyleejordan
force-pushed
the
andschwa/ci-stability
branch
from
7d166b5 to
d8e76d2
Compare
Our CI can be quite slow, and these were just arbitrary timeouts. If the tests succeed, they should never be hit. Let's instead give them as much time as possible. CI will eventually kill the run if it hangs, and locally devs can do the same. This should help improve CI stability. Also fixes the disposal bug in the tests.
andyleejordan
force-pushed
the
andschwa/ci-stability
branch
from
d8e76d2 to
7eefe68
Compare
andyleejordan
force-pushed
the
andschwa/ci-stability
branch
from
7eefe68 to
80ab5a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing arbitrary timeouts, fixing disposal bugs, and cleaning up tests. Resolves #1793.