Fix duplicate DiagnosticMarkers when reopening a file #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Broke parser-errors. TBC |
|
Wow, nice fix @fflaten! Thanks so much, this one had been bugging me immensely. |
src/PowerShellEditorServices/Services/Analysis/AnalysisService.cs
Outdated
Show resolved
Hide resolved
Same, which is why I really had to give PSES debugging a second attempt again. Last time was when I created the issue. 😄 So thank you! |
andyleejordan
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Clears the cached DiagnosticsMarkers for a file before adding new results from full script analysis.
PR Context
Reopening a file with PSSA-findings will be duplicated each time the file is closed and reopened.
Fix PowerShell/vscode-powershell#3252