Skip to content

Update shell integration script to fix command decorations #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

andyleejordan
Copy link
Member

Happy new year! Updated one year ago today, it needed it again. This has actually been broken for a while unfortunately because the last time we manually patched it to disable strict mode, we did so before capturing the exit code (and thus it was lost). Fixed now at least.

Fixes PowerShell/vscode-powershell#4854 and PowerShell/vscode-powershell#4864.

Happy new year! Updated one year ago today, it needed it again. This has
actually been broken for a while unfortunately because the last time we
manually patched it to disable strict mode, we did so before capturing
the exit code (and thus it was lost). Fixed now at least.
@andyleejordan andyleejordan marked this pull request as ready for review January 3, 2024 22:41
@andyleejordan andyleejordan requested a review from a team January 3, 2024 22:41
@andyleejordan andyleejordan added this pull request to the merge queue Jan 3, 2024
Merged via the queue into main with commit 27b279e Jan 3, 2024
@andyleejordan andyleejordan deleted the andyleejordan/update-shell-integration branch January 3, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Command decoration indicates success (blue dot) if the command failed (exit code > 0)
2 participants