Interrupt integrated console command prompt when commands are executed #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a general class of problems in the integrated console experience where commands that were executed internally (like extension commands or running Plaster templates) do not interrupt the command prompt, causing future input to be written over previous output lines. The fix is to have the command prompt be interrupted by any commands which write output or errors to the host. Fixes PowerShell#411.
This change fixes an issue where invoking a Plaster template from within VS Code causes Plaster prompts to be handled incorrectly because the command prompt has not been interrupted. The fix is to request that the command prompt be interrupted when Invoke-Plaster is called. Fixes PowerShell/vscode-powershell#643.
This change fixes a couple of issues that appear when the user presses Enter to accept default values of input or choice prompts. This issue appeared when running through the default New Project template that is shipped with Plaster. Fixes PowerShell/vscode-powershell#504.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a general class of problems in the integrated console
experience where commands that were executed internally (like extension
commands or running Plaster templates) do not interrupt the command
prompt, causing future input to be written over previous output lines.
The fix is to have the command prompt be interrupted by any commands
which write output or errors to the host.
Fixes #411.