Remove static Logger API in favor of ILogger instance usage #488
+967
−577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces the ILogger interface to abstract writing log messages to an arbitrary sink so that this interface can be passed to other components for logging behavior. It also adds the FileLogger implementation which is a refactored LogWriter implementation.
This change continues the decoupling with the current codebase from the static Logger classes and transitions to using ILogger instances for writing log messages. There are still a couple uses of a static ILogger instance but they will be removed in an upcoming PR that refactors our PSHost implementations.
|
Going to forge ahead on this because I've got some work to do tomorrow that depends on it! Let me know if you have any questions or concerns. |
|
I like this "DI" style approach. It is what I use in my code at work where I often have a NullLogger when I don't care about log output. |
|
Yep, the refactoring that I'm doing is gradually moving everything to a DI model, you can see more of that in my latest PR 😄 I like being able to throw a dummy implementation in where something isn't needed. It'll definitely make some of the code easier to test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty big change because it touches every usage of
Logger.Writein the codebase and adds new parameters to pass around an ILogger instance to individual components. This is another incremental change toward the new PSES-as-a-framework model so that third-party extension modules will be able to add logs to the EditorServices.log file.