Add position function set to Commands #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a custom implementation of IScriptExtent similar to InternalScriptExtent. The major difference being the replacement of PositionHelper with FileContext. The PositionHelper class was used to store the full script text and line start mapping for all ScriptExtent objects of the same file. FileContext is a great replacement for this because it's already kept unique by PSES and it adapts to changes. - Added FullScriptExtent and FullScriptPosition classes. - Changed the scriptFile field on FileContext from private to internal.
This class will be used by Import-EditorCommand to target commands for registration as editor commands.
This changes adds commands from PSESHelperLibrary that assist with locating and manipulating text based on the syntax tree or position. - Changed functions to be compatible with PowerShell 3. - Adapted functions to use FullScriptExtent objects for position instead of using reflection to create InternalScriptExtents
- Add standard function loading process. - Add functions to export list in manifest. - Update manifest with a unique guid. - Add localized data file loading.
This change adds markdown help for all added functions. It also adds a step in the build process to create the MAML XML file.
- Fix an issue with parameter set resolution in ConvertTo-ScriptExtent. - Fix importing editor commands from a module that is in the middle of being imported. - Add parameter validation to FullScriptExtent constructors.
- Added online link to markdown help. - Converted comment based help of Register-EditorCommand and UnregisterEditorCommand to markdown. - Fixed psedit not being exported. - Added cleanup of generated MAML file to build script.
|
@SeeminglyScience, |
|
Awesome! Thanks a lot for sending this, I'll give it a full review later. Looks like AppVeyor needs to have PlatyPS installed, you can add the Install-Module line for that to appveyor.yml. |
|
Looks like the Travis init script also needs to be updated, sorry I forgot to mention that! https://github.com/PowerShell/PowerShellEditorServices/blob/master/scripts/travis.ps1 |
daviwil
approved these changes
Jun 8, 2017
| @@ -15,7 +15,7 @@ RootModule = 'PowerShellEditorServices.Commands.psm1' | |||
| ModuleVersion = '1.0.0' | |||
|
|
|||
| # ID used to uniquely identify this module | |||
| GUID = '9ca15887-53a2-479a-9cda-48d26bcb6c47' | |||
| GUID = '6064d846-0fa0-4b6d-afc1-11e5bed3c4a9' | |||
There was a problem hiding this comment.
Thanks! I realized I screwed that up after I merged the PR ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a set of functions to assist with finding and manipulating positions in script files. This also includes the
Import-EditorCommandwhich will register any function from a module that has theEditorCommandAttributeattached to it.This is the full list of added commands: