add Save to FileContext API

[TylerLeonhardt]

This is the PSES portion of this change. See the PSES portion here: PowerShell/vscode-powershell#1139

Please let me know if I'm missing something.

To test this, you can use:

$psEditor.GetEditorContext().CurrentFile.Save()

in the Integrated Console.

[rkeithhill]

LGTM but this is way more @daviwil area.

[SeeminglyScience]

Would adding to this interface be a breaking change? I know we have at least two new implementations of PSES since this interface was last changed. Should new features be added as additional interfaces, something like IEditorSaveOperations?

[TylerLeonhardt]

Good point.. but I think if we were going to make a new interface, I'd want it to be IEditorFileOperations and it would contain NewFile, OpenFile, CloseFile, SaveFile`, ya know? And that would surely warrant a breaking change.

[daviwil]

As far as I know, nobody is using these interfaces outside of PSES itself. Adding a method to an interface wouldn't be a breaking change so I think a new interface shouldn't be necessary for this.

[SeeminglyScience]

If you pass ClientFilePath here instead of FilePath you should be able to avoid resolving the path when it gets to VSCode. The InsertText method is a good example for both sides.

[TylerLeonhardt]

@SeeminglyScience + @daviwil: So I tried passing in ClientFilePath. It prefaced it with file://.

This is not ideal because for openFile and closeFile here:
https://github.com/PowerShell/vscode-powershell/blob/master/src/features/ExtensionCommands.ts#L362-L409

We have VSCode already resolving the paths.

So I think we should either continue resolving the paths via VSCode, or modify openFile and closeFile to expect a ClientFilePath as well. That way, we are consistent.

Thoughts?

[SeeminglyScience]

@tylerl0706 Ah I'd keep it as is then. In general I think it's better to have PSES do the work, but it's probably not worth changing the others.

[daviwil]

As far as I know, nobody is using these interfaces outside of PSES itself. Adding a method to an interface wouldn't be a breaking change so I think a new interface shouldn't be necessary for this.

[TylerLeonhardt]

Thanks all!

[rkeithhill]

@tylerl0706 I think we missed a file here because I don't see the SaveFile command e.g.:

I think SaveFile needs to be implemented here:

PowerShellEditorServices/src/PowerShellEditorServices/Extensions/EditorWorkspace.cs

Lines 41 to 61 in 0f63e5c

	#region Public Methods
	/// <summary>
	/// Creates a new file in the editor
	/// </summary>
	public void NewFile()
	{
	this.editorOperations.NewFile().Wait();
	}
	/// <summary>
	/// Opens a file in the workspace. If the file is already open
	/// its buffer will be made active.
	/// </summary>
	/// <param name="filePath">The path to the file to be opened.</param>
	public void OpenFile(string filePath)
	{
	this.editorOperations.OpenFile(filePath).Wait();
	}
	#endregion

BTW CloseFile() is missing as well. Hmm, maybe I'm not looking in the right place for this new SaveFile method.

UPDATE: nevermind. Figured it out - $psEditor.GetEditorContext().CurrentFile.Save().