change Enumerate* to Get* #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
requested review from
daviwil,
rkeithhill and
SeeminglyScience
rkeithhill
reviewed
Jan 22, 2018
| @@ -274,7 +274,7 @@ private IEnumerable<string> RecursivelyEnumerateFiles(string folderPath) | |||
| { | |||
| foundFiles = | |||
| foundFiles.Concat( | |||
| Directory.EnumerateFiles( | |||
| Directory.GetFiles( | |||
There was a problem hiding this comment.
While you're at it, can you add the check for PathTooLongException below using a catch exception filter:
catch (Exception ex) when {ex is UnauthorizedException || ex is PathTooLongException) { ... }
You might want to check DirectoryNotFoundException in case someone deletes a dir while we're searching.
rkeithhill
approved these changes
Jan 22, 2018
SeeminglyScience
approved these changes
Jan 22, 2018
rkeithhill
reviewed
Jan 22, 2018
| @@ -278,10 +278,22 @@ private IEnumerable<string> RecursivelyEnumerateFiles(string folderPath) | |||
| folderPath, | |||
| pattern)); | |||
| } | |||
| catch (UnauthorizedAccessException e) | |||
| catch (DirectoryNotFoundException e) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @daviwil mentioned in #612,
He was correct! Changing the Enumerates to Gets did the trick. Verified this on macOS by opening up a big workspace and finding all references/go to definition.
Resolves #612
Resolves PowerShell/vscode-powershell#908
Resolves daviwil/ide-powershell#1