Add Start-EditorServices script from vscode-powershell repo #639
Conversation
|
Sorry this can actually replace the contents of this: |
|
Just make sure we keep the version with the recently added logging info. :-) |
|
@rkeithhill yeah that PR was in vscode-powershell :) |
|
There's 1 test failure I'm trying to figure out. Not sure if it's a bad test or not. |
|
wait... that's not running all the tests. |
|
I got them all to run with this: |
| @@ -11,6 +11,7 @@ | |||
| using System.Diagnostics; | |||
| using System.IO; | |||
| using System.Text; | |||
There was a problem hiding this comment.
Can you add this right before this line:
#if CoreCLR
using System.Reflection;
#endif
Without this, my build within VS 2017 fails with:
Severity Code Description Project File Line Suppression State
Error CS1061 'Type' does not contain a definition for 'GetTypeInfo' and no extension method 'GetTypeInfo' accepting a first argument of type 'Type' could be found (are you missing a using directive or an assembly reference?) PowerShellEditorServices.Test.Host(netcoreapp2.0) C:\Users\Keith\GitHub\rkeithhill\PowerShellEditorServices\test\PowerShellEditorServices.Test.Host\ServerTestsBase.cs 42 Active
Change to check length of sessionPath file and only if file exists test passes. Update to use CodeBase which is the original location of the file under bin dir. Location is in the temp dir when run under xUnit.
|
@rkeithhill IS THE BEST |
|
@rkeithhill Wait, so do we want |
rjmholt
force-pushed
the
add-startpses-script
branch
from
235a4f6 to
3d8a322
Compare
|
Oh, I see, @tylerl0706 already fixed it. Just got rid of that last commit |
|
LGTM |
|
Alright, I'm going to merge this in since we currently use the Start-EditorServices.ps1 file so we know that works and the tests are all passing. |
Simplified extension setting description strings
Adds the Start-EditorServices.ps1 script into the actual PowerShellEditorServices repo, to make PSES self-contained