Stop before we restart #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rjmholt
approved these changes
May 22, 2018
There was a problem hiding this comment.
I looked through the code and noticed that Stop() isn't used anywhere else (as far as I can tell). Was going to suggest a Restart() method.
But to be honest, Stop() seems pretty reasonable.
I'm assuming this works with TCP too? (I saw stdio has Stop() as a no-op).
LGTM!
|
@rjmholt yep! TCP still work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PSES's debug adapter wasn't properly shutting down between debug sessions (some things were shut down, some things weren't). This might have been the cause of other debug issues we have seen when/if folks have been unable to restart the debugger.
This change is needed to get NamedPipes working because when running Start without fully Stopping before it, the debug adapter would crash with: