Fix PSES crash when you format an empty PS doc #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoke-Formatter -ScriptDefinition '' - throws a terminating error: ParameterBinderValidationException. I suppose we could have added another catch statement to the InvokePowerShell method in the AnalysisService but in general, we probably want to know about such bugs. Also, we could also update the extension to not send a format request for an empty doc but I'm not sure it's worth the additional code change given corner case scenario. But I could be convinced otherwise.
rkeithhill
changed the title
rkeithhill
changed the title
rjmholt
approved these changes
Jun 11, 2018
There was a problem hiding this comment.
LGTM. Agreed on not catching the exception -- it's much more performant this way, and doing it the other way would probably just pollute the logs.
Also, I agree with handling it on the server side -- if the behaviour of Invoke-Formatter were to change, it would make more sense to me to make the change here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoke-Formatter -ScriptDefinition '' - throws a terminating error:
ParameterBinderValidationException.
I suppose we could have added another catch statement to the InvokePowerShell method
in the AnalysisService but in general, we probably want to know about such bugs.
We could also update the extension to not send a format request for an empty doc
but I'm not sure it's worth the additional code change given this corner case scenario.
But I could be convinced otherwise.
This is a partial fix to vscode issue PowerShell/vscode-powershell#1346 (comment)