Skip to content

Fixed #692 #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Fixed #692 #693

merged 1 commit into from
Jun 28, 2018

Conversation

adamdriscoll
Copy link
Contributor

@adamdriscoll adamdriscoll commented Jun 27, 2018

Set DocumentRangeFormattingProvider value to false.

Fixes #692

@TylerLeonhardt
Copy link
Member

Hey Adam! Does this mean a Editor Services enabled Posh Tools is coming? 🤔😊

A lot of people are excited about it!

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adamdriscoll
Copy link
Contributor Author

@tylerl0706 I'm putting together a separate repo for testing. There is just so much code in PoshTools that it makes it super difficult to work on just the language\debug server without effecting everything else. Additionally, I hope to use common project system in this repo to see how much of PoshTools I can mimic with as minimal code as possible.

https://github.com/adamdriscoll/vs-powershell

Moving forward, I'll have to see how I merge that back into the PoshTools repo.

@adamdriscoll
Copy link
Contributor Author

Seems like Preview 3 of 15.8 isn't working with LSPs though...I can't get mine or the Rust one to work properly.

@TylerLeonhardt TylerLeonhardt merged commit e621bc0 into PowerShell:master Jun 28, 2018
@TylerLeonhardt
Copy link
Member

@adamdriscoll let me know if you need contacts on the VS team. We can spin up that email thread again to get you unblocked 😄

also, congrats on the engagement!

@adamdriscoll
Copy link
Contributor Author

@tylerl0706 - That'd be great! I'm not really sure how to debug it.

And thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants