Remove unnecessary LINQ calls from LanguageServer #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
requested review from
TylerLeonhardt,
rkeithhill and
SeeminglyScience
SeeminglyScience
approved these changes
Sep 5, 2018
rkeithhill
reviewed
Sep 10, 2018
| else | ||
| { | ||
| symbols = new SymbolInformation[0]; | ||
| var symbolAcc = new List<SymbolInformation>(); |
There was a problem hiding this comment.
This all looks great. Just curious what the Acc in symbolAcc is short for? Accumulator?
There was a problem hiding this comment.
Sorry, accumulator, yes. Habit from writing tail-recursive folds in other languages. Maybe I should change it to something more obvious? Always conscious that having so many variables named essentially the same thing is a code smell, so open to suggestions :)
There was a problem hiding this comment.
Not a big deal. Just wanted to make sure I understood what it meant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a few LINQ calls from the Language Server, in an effort to chip away at performance issues.
Given how complicated and central the logic here is, I haven't made any style changes, but would be happy to make any :)