Use PSRL release and filter out previous betas #745

rjmholt · 2018-09-06T04:31:50Z

Uses the PSReadLine beta3 release from PowerShell gallery instead of downloading the master build from AppVeyor
Filters out the old beta versions that don't have @SeeminglyScience's private API in it (which effectively break us trying to pull PSRL2 in)

Quick question: is there anything else that needs changing for better PSRL module support here?

TylerLeonhardt · 2018-09-06T04:35:25Z

lolololol

TylerLeonhardt · 2018-09-06T04:40:06Z

src/PowerShellEditorServices/Session/PSReadLinePromptContext.cs

-                $module = Get-Module -ListAvailable PSReadLine | Where-Object Version -ge '2.0.0' | Sort-Object -Descending Version | Select-Object -First 1
+                $module = Get-Module -ListAvailable PSReadLine `
+                    | Where-Object Version -ge '2.0.0' `
+                    | Where-Object { $psd = Import-PowerShellDataFile $_.Path; $release = $psd.PrivateData.PSData.Prerelease; -not (@('beta1', 'beta2') -contains $release) } `


I can't believe we need to do this lol

TylerLeonhardt

🚢 it

rkeithhill · 2018-09-06T04:45:42Z

src/PowerShellEditorServices/Session/PSReadLinePromptContext.cs

-                $module = Get-Module -ListAvailable PSReadLine | Where-Object Version -ge '2.0.0' | Sort-Object -Descending Version | Select-Object -First 1
+                $module = Get-Module -ListAvailable PSReadLine `
+                    | Where-Object Version -ge '2.0.0' `
+                    | Where-Object { $psd = Import-PowerShellDataFile $_.Path; $release = $psd.PrivateData.PSData.Prerelease; -not (@('beta1', 'beta2') -contains $release) } `


Maybe simplify a bit with $release -notin @('beta1','beta2')? If only we had a SemanticVersion class we could use for sorting in Win PS 5.

Aha! I wondered if an operator like that existed

rkeithhill

LGTM

SeeminglyScience

LGTM except some nits

src/PowerShellEditorServices/Session/PSReadLinePromptContext.cs

rjmholt · 2018-09-11T03:10:25Z

Anyone know why it suddenly doesn't like -AllowPrereleaseVersions?

rjmholt · 2018-09-11T03:12:06Z

I've tried @tylerl0706's suggestions: https://www.powershellgallery.com/packages/PowerShellGet/1.5.0.0

Works fine on my machines though

rjmholt · 2018-09-11T03:25:54Z

Gah https://github.com/PowerShell/PowerShellGet/issues/208

scripts/travis.ps1

appveyor.yml

TylerLeonhardt · 2018-09-12T22:23:02Z

src/PowerShellEditorServices/Session/PSReadLinePromptContext.cs

@@ -20,7 +20,7 @@ internal class PSReadLinePromptContext : IPromptContext {
            [System.Diagnostics.DebuggerHidden()]
            [System.Diagnostics.DebuggerStepThrough()]
            param()
-            return [Microsoft.PowerShell.PSConsoleReadLine]::ReadLine(
+            return [Microsoft.PowerShell.PSConsoleReadLine, Microsoft.PowerShell.PSReadLine2, Version=2.0.0.0, Culture=neutral, PublicKeyToken=null]::ReadLine(


@rkeithhill, @SeeminglyScience turns out:

PSCore 6.0 bundles and loaded PSReadLine.dll in $PSHome, so we need to use the assembly-qualified name of the type and we have to provide the version for it to work

Windows PowerShell doesn't like assembly-qualified names without the Culture and PublicKeyToken, so I had to add that too...........

But it works and we can take it out when PSCore 6.0 support is ended

On the bright side it's still a whole lot better than having to manually replace the DLL!

TylerLeonhardt · 2018-09-12T22:23:51Z

Can you open an issue to remind us to remove that fully qualifying when 6.0 goes out of support?

* Use PSRL release and filter out previous betas * Use fully qualified type name for broad PowerShell support * Fix CI module installation

@bergmeister

* Add infrastructure for managing context Adds classes that manage the state of the prompt, nested contexts, and multiple ReadLine implementations of varying complexity. (cherry picked from commit 7ca8b9b) * Console related classes changes Change ReadLine method to call out to PowerShellContext. This lets the PowerShellContext determine which ReadLine implementation to use based on available modules. Also includes some changes to the System.Console proxy classes to account for PSReadLine. (cherry picked from commit 59bfa3b) * Rewrite command invocation operations for PSRL Refactor PowerShellContext to have a more robust system for tracking the context in which commands are invoked. This is a significant change in that all interactions with the runspace must be done through methods in PowerShellContext. These changes also greatly increase stability. (cherry picked from commit 21e6b5f) * Rewrite direct SessionStateProxy calls All interactions with the runspace must be done through PowerShellContext now that nested PowerShell instances are encountered frequently. Also fix a bunch of race conditions that were made more obvious with the changes. (cherry picked from commit fa2faba) * Pass feature flags to Start-EditorServicesHost * Address feedback and fix travis build error - Address feedback from @bergmeister - Fix a few other similar mistakes I found - Fix travis build failing due to missing documentation comment tag * Fix all tests except ServiceLoadsProfileOnDemand - Fix an issue where intellisense wouldn't finish if PSReadLine was not running - Fix a crash that would occur if the PSHost was not set up for input like the one used in our tests - Fix a compile error when building against PSv3/4 - Fix a hang that occurred when the PromptNest was disposed during a debug session - Fix some XML documentation comment syntax errors * Fix extra new lines outputted after each command Removed a call to WriteOutput where it wasn't required. This was creating extra new lines which failed tests (and obviously didn't look right). * Remove unused field from InvocationEventQueue And also fix spacing between the other fields. * Remove copying of PDB's in build script @rjmholt did a better job of this in a different PR that we can merge into 2.0.0 later. It also doesn't make sense in this PR. * Add AppVeyor tracking to branch 2.0.0 * Fix ambiguous method crash on CoreCLR Simplify delegate creation in PSReadLineProxy and fix the immediate ambiguous method crash the complicated code caused on CoreCLR. * first round of feedback changes * Some more feedback changes * add a bunch of copyright headers I missed * remove KeyAvailable query * Get the latest PSReadLine module installed * Add PSReadLine installation to build script * the file should be downloaded as a .zip * Address remaining feedback * Attempt to fix issue with native apps and input On Unix like platforms some native applications do not work properly if our event subscriber is active. I suspect this is due to PSReadLine querying cursor position prior to checking for events. I believe the cursor position response emitted is being read as input. I've attempted to fix this by hooking into PSHost.NotifyBeginApplication to temporarly remove the event subscriber, and PSHost.NotifyEndApplication to recreate it afterwards. * Revert "Attempt to fix issue with native apps and input" This reverts commit 1682410. * Fix build failure Use latest PSReadLine (PowerShell#745) * Use PSRL release and filter out previous betas * Use fully qualified type name for broad PowerShell support * Fix CI module installation

Use PSRL release and filter out previous betas

6a3cf95

rjmholt requested review from TylerLeonhardt, rkeithhill and SeeminglyScience September 6, 2018 04:31

TylerLeonhardt reviewed Sep 6, 2018

View reviewed changes

TylerLeonhardt approved these changes Sep 6, 2018

View reviewed changes

rkeithhill reviewed Sep 6, 2018

View reviewed changes

rkeithhill approved these changes Sep 6, 2018

View reviewed changes

Use -notin operator

1ade357

SeeminglyScience approved these changes Sep 6, 2018

View reviewed changes

src/PowerShellEditorServices/Session/PSReadLinePromptContext.cs Outdated Show resolved Hide resolved

src/PowerShellEditorServices/Session/PSReadLinePromptContext.cs Outdated Show resolved Hide resolved

Improve module import script style

c9a8d2f

TylerLeonhardt approved these changes Sep 7, 2018

View reviewed changes

Robert Holt added 2 commits September 10, 2018 19:57

Use latest NuGet provider

864c418

Install newer powershellget

3a0b4e8

Robert Holt added 2 commits September 10, 2018 20:13

Fix AllowPrerelease flag

3866833

Change parameter name back

56c640a

Robert Holt added 5 commits September 10, 2018 20:36

Try harder to get a better packageget version

7598faa

Put first install module in another process

4839354

Try more thigns

af7fa23

Make travis also use the right version of packageget

d631469

Make travis installation user-local

2777139

TylerLeonhardt reviewed Sep 11, 2018

View reviewed changes

scripts/travis.ps1 Show resolved Hide resolved

TylerLeonhardt reviewed Sep 11, 2018

View reviewed changes

appveyor.yml Show resolved Hide resolved

Use fully qualified assembly name for PSReadLine loading for PSCore 6.0

1d97cc0

TylerLeonhardt reviewed Sep 12, 2018

View reviewed changes

rjmholt merged commit 0a29e44 into PowerShell:2.0.0 Sep 13, 2018

rjmholt added a commit to rjmholt/PowerShellEditorServices that referenced this pull request Oct 2, 2018

Use latest PSReadLine (PowerShell#745)

59ad265

* Use PSRL release and filter out previous betas * Use fully qualified type name for broad PowerShell support * Fix CI module installation

rjmholt added a commit to rjmholt/PowerShellEditorServices that referenced this pull request Oct 2, 2018

Use latest PSReadLine (PowerShell#745)

33e9fd2

* Use PSRL release and filter out previous betas * Use fully qualified type name for broad PowerShell support * Fix CI module installation

rjmholt deleted the psrl-beta3-release branch December 12, 2018 06:02

rjmholt added a commit to rjmholt/PowerShellEditorServices that referenced this pull request Jan 18, 2019

Use latest PSReadLine (PowerShell#745)

4cc0ea9

* Use PSRL release and filter out previous betas * Use fully qualified type name for broad PowerShell support * Fix CI module installation

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use PSRL release and filter out previous betas #745

Use PSRL release and filter out previous betas #745

rjmholt commented Sep 6, 2018

TylerLeonhardt commented Sep 6, 2018

TylerLeonhardt Sep 6, 2018

TylerLeonhardt Sep 6, 2018

rjmholt Sep 6, 2018

TylerLeonhardt left a comment

rkeithhill Sep 6, 2018

rjmholt Sep 6, 2018

rkeithhill left a comment

SeeminglyScience left a comment

rjmholt commented Sep 11, 2018

rjmholt commented Sep 11, 2018

rjmholt commented Sep 11, 2018

TylerLeonhardt Sep 12, 2018

rjmholt Sep 12, 2018

SeeminglyScience Sep 12, 2018

TylerLeonhardt commented Sep 12, 2018

Use PSRL release and filter out previous betas #745

Use PSRL release and filter out previous betas #745

Conversation

rjmholt commented Sep 6, 2018

TylerLeonhardt commented Sep 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TylerLeonhardt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rkeithhill left a comment

Choose a reason for hiding this comment

SeeminglyScience left a comment

Choose a reason for hiding this comment

rjmholt commented Sep 11, 2018

rjmholt commented Sep 11, 2018

rjmholt commented Sep 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TylerLeonhardt commented Sep 12, 2018