Fix crash for finding symbols on bad paths #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -346,9 +347,13 @@ public FindOccurrencesResult FindSymbolsInFile(ScriptFile scriptFile) | |||
| { | |||
| scriptFile = workspace.GetFile(file); | |||
| } | |||
| catch (IOException) | |||
| catch (Exception e) when (e is IOException | |||
| || e is SecurityException | |||
There was a problem hiding this comment.
Does SecurityException include the "can't access due to permissions"?
There was a problem hiding this comment.
Wow, I foolishly trusted that it did because the FileStream constructor docs only mention the exceptions I included here, but it looks like it doesn't >:(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PowerShell/vscode-powershell#1518.
Protects against trying to open bad paths from
ScriptFile.GetFile()in the symbol provider.This fixes the given issue, but might not be the best way to do so -- perhaps better for
GetFile()to return null in this case?But we can change that at some later point perhaps.