Skip to content

Make pipeline runtime exceptions warnings in log #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2018
Merged

Make pipeline runtime exceptions warnings in log #768

merged 1 commit into from
Oct 11, 2018

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Oct 10, 2018

Resolves PowerShell/vscode-powershell#1573.

Marks runtime executions from PowerShellContext.Invoke() as WARNINGs not ERRORs, since they don't crash the extension and often cause distraction in the log.

TylerLeonhardt
TylerLeonhardt approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SeeminglyScience
SeeminglyScience approved these changes Oct 10, 2018
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rkeithhill
rkeithhill approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjmholt rjmholt merged commit a0bf7e1 into PowerShell:master Oct 11, 2018
@rjmholt rjmholt deleted the exceeded-stack-frame-warning branch December 12, 2018 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

@rkeithhill rkeithhill rkeithhill approved these changes

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rjmholt @TylerLeonhardt @rkeithhill @SeeminglyScience