Fix local remoting #801
Merged
Fix local remoting #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeeminglyScience
approved these changes
Nov 29, 2018
PaulHigin
approved these changes
Nov 29, 2018
|
|
||
| // hostname is 'ServerRemoteHost' when the user enters a session. | ||
| // ex. Enter-PSSession, Enter-PSHostProcess | ||
| if (hostname == "ServerRemoteHost") | ||
| { | ||
| runspaceId = |
There was a problem hiding this comment.
This runspaceId variable doesn't seem to be used anywhere, and perhaps it is not needed. Also the default value returned should not be runspace, but a default runspace id.
There was a problem hiding this comment.
I've deleted that line of code. Thanks @PaulHigin!
|
Thanks @PaulHigin! |
Co-Authored-By: TylerLeonhardt <[email protected]>
Co-Authored-By: TylerLeonhardt <[email protected]>
Co-Authored-By: TylerLeonhardt <[email protected]>
Co-Authored-By: TylerLeonhardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if you did:
or any variation that uses localhost... this would get marked as a "Local" session and psedit would not get registered (other bad things could have been happening too...).
This fix makes all PSRP sessions "Remote" sessions so that psedit registers correctly.
This also allows a user to start ssh server in WSL or a container and use:
to get remote editing & debugging in PSES