Use case insensitive dictionary for Pester keyword lookup so that code lens shows when using lower cased describe keyword #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e lens shows when using lower cased describe keyword
|
You're correct, my friend :) |
|
I would very much so like to spend the time to improve the dev experience. Thanks for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #822 by using a case insensitive dictionary so that when
PesterKeyWords.TryGetValuegets called here the code lens in VS-Code shows also when using a lower caseddescribekeywordHowever, I have not tested this fix since building a VS-Code extension end-to-end is not very easy for a contributor that is new to the code base, I came up with this purely just by looking at the code. Since PSES has to integrate with the vs-code extension anyway, it would be great if CI produced an extension package for easy local manual testing and also automated integration testing