Fix issue with reference code lens not working with UNC paths #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
approved these changes
Apr 5, 2019
rjmholt
approved these changes
Apr 5, 2019
|
I changed the code enough to warrant another review. The Windows code path is a bit more complicated but it avoids having to do inserts later by appending chars as required from the start. Although the |
rjmholt
reviewed
Apr 8, 2019
|
Due to constant crashing with UNC PS1 files, I've rolled back to PowerShell-1.11.0.vsix and have disabled auto updating. It's been constantly poor code quality that is super disappointing with this extension all around the last four months. |
rkeithhill
force-pushed
the
rkeithhill/fix-codelens-ref-unc-path
branch
from
db9dd7e to
0a89523
Compare
rkeithhill
added a commit
to rkeithhill/PowerShellEditorServices
that referenced
this pull request
Apr 10, 2019
…hell#908) * Fix issue with reference code lens not working with UNC paths * Refactor to avoid extra Insert ops. Simplifies macOS/Linux code path. * Still need to unescape / on macOs & Linux * Replace compile-time check for .NET Core with runtime check
rjmholt
pushed a commit
that referenced
this pull request
Apr 10, 2019
…917) * Fix issue with reference code lens not working with UNC paths * Refactor to avoid extra Insert ops. Simplifies macOS/Linux code path. * Still need to unescape / on macOs & Linux * Replace compile-time check for .NET Core with runtime check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few of the failure modes (related to UNC paths) for PowerShell/vscode-powershell#1830