win32: Fix enumerate root dir content on SFTP-server #148
Conversation
remittor
commented
May 24, 2017
•
remittor
commented
remittor
force-pushed
the
v75-enum-root-dir
branch
2 times, most recently
from
09138e2 to
02fc287
Compare
Enum logical drives using GetLogicalDriveStringsW.
remittor
force-pushed
the
v75-enum-root-dir
branch
from
02fc287 to
ecdb393
Compare
|
|
||
| /* Detect root dir */ | ||
| if (path && strcmp(path, "/") == 0) { | ||
| buf->st_mode = _S_IFDIR | _S_IREAD | 0xFF; |
| /* Detect root dir */ | ||
| if (path && strcmp(path, "/") == 0) { | ||
| buf->st_mode = _S_IFDIR | _S_IREAD | 0xFF; | ||
| buf->st_dev = USHRT_MAX; // rootdir flag |
There was a problem hiding this comment.
ATTR_ROOTDIR is 32 bit
buf->st_dev is 16 bit
There was a problem hiding this comment.
what is the need for setting this here as we are not using this any where else?
There was a problem hiding this comment.
You can remove this line, if it so cuts your eyes.
There was a problem hiding this comment.
We should remove the unnecessary code so its easy to maintain the long run..
| continue; | ||
|
|
||
| x = GetDiskFreeSpaceExW(p, NULL, &totalNumberOfBytes, NULL); | ||
| if (!x || totalNumberOfBytes.QuadPart == 0) |
There was a problem hiding this comment.
I think, we can remove "totalNumberOfBytes.QuadPart == 0"
There was a problem hiding this comment.
Var totalNumberOfBytes.QuadPart equ 0 when CD-drive have not CD-disk.
| memset(buf, 0, sizeof(struct _stat64)); | ||
|
|
||
| /* Detect root dir */ | ||
| if (path && strcmp(path, "/") == 0) { |
There was a problem hiding this comment.
from winscp (or) any other third party software.. if we receive "/" then it is treated as the root dir....
But I am not sure if all the thirdparty softwares follow the same notion.. not sure if some of them can use \ instead of "/", is it possible.. is there a standard notion?
There was a problem hiding this comment.
I tested this PR in WinSCP and Bitvise SFTP-clients.
