Fixed issue with binary input stream over ssh #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagajjal
reviewed
May 30, 2017
| process_input = TRUE; | ||
| else { | ||
| command_len = wcsnlen_s(command, MAX_CMD_LEN); | ||
| if ((command_len >= 3 && wcsncmp(command, L"cmd", 4) == 0) || |
There was a problem hiding this comment.
what about powershell?
.\ssh.exe [email protected] powershell
There was a problem hiding this comment.
The input processing logic is exclusively for cmd.exe. Powershell is a shell processor/interpreter in itself. It should not be included here to give it independence to do whatever it wants with the input stream (ex. it could support direction keys, etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PowerShell/Win32-OpenSSH#658
Manually tested for now. Test case needs to be added tracked as PowerShell/Win32-OpenSSH#740
Also includes changes to HLA ppt