Fix Right Click Help lookup not always working. (#1743)

corbob · TylerLeonhardt · commit 3c44983af353 · 2019-03-20T09:47:20.000-07:00
* Check that item has a Name property

* Update src/features/ShowHelp.ts

Do a truthy check instead.

Co-Authored-By: corbob &lt;30301021+corbob@users.noreply.github.com&gt;
diff --git a/src/features/ShowHelp.ts b/src/features/ShowHelp.ts
@@ -22,7 +22,7 @@ export class ShowHelpFeature implements IFeature {
                     "Unable to instantiate; language client undefined.");
                 return;
             }
-            if (item === undefined) {
+            if (!item || !item.Name) {
 
                 const editor = vscode.window.activeTextEditor;
 

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ export class ShowHelpFeature implements IFeature {`
`22`	`22`	`"Unable to instantiate; language client undefined.");`
`23`	`23`	`return;`
`24`	`24`	`}`
`25`		`- if (item === undefined) {`
	`25`	`+ if (!item \|\| !item.Name) {`
`26`	`26`
`27`	`27`	`const editor = vscode.window.activeTextEditor;`
`28`	`28`