Fix Right Click Help lookup not always working. #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
reviewed
Feb 6, 2019
Do a truthy check instead. Co-Authored-By: corbob <[email protected]>
rjmholt
approved these changes
Feb 8, 2019
TylerLeonhardt
pushed a commit
to TylerLeonhardt/vscode-powershell
that referenced
this pull request
Mar 18, 2019
* Check that item has a Name property * Update src/features/ShowHelp.ts Do a truthy check instead. Co-Authored-By: corbob <[email protected]>
TylerLeonhardt
pushed a commit
that referenced
this pull request
Mar 20, 2019
* Check that item has a Name property * Update src/features/ShowHelp.ts Do a truthy check instead. Co-Authored-By: corbob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1740
When selecting Show Help from right click menu, vscode is sending the editor information through the item parameter. The editor doesn't have a Name property, so we should check that the item being passed has a Name property as well.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.