Running Save Participants dialog is hanging on save and preventing the script from saving

[MarkKharitonov]

Issue Description

Saving a ps1 script opens a "Running Save Participants ..." dialog that just hangs. Saving does not proceed until the dialog is closed.

Attached Logs

logs.zip

Environment Information

Visual Studio Code

Name	Version
Operating System	Windows_NT x64 10.0.17763
VSCode	1.42.1
PowerShell Extension Version	2020.3.0

PowerShell Information

Name	Value
PSVersion	5.1.17763.1007
PSEdition	Desktop
PSCompatibleVersions	1.0 2.0 3.0 4.0 5.0 5.1.17763.1007
BuildVersion	10.0.17763.1007
CLRVersion	4.0.30319.42000
WSManStackVersion	3.0
PSRemotingProtocolVersion	2.3
SerializationVersion	1.1.0.1

Visual Studio Code Extensions

Visual Studio Code Extensions(Click to Expand)

Extension	Author	Version
powershell	ms-vscode	2020.3.0

[TylerLeonhardt]

This is very strange... a quick search says it might be a vscode bug: https://github.com/search?q=%22Running+Save+Participants%22&type=Code

[MarkKharitonov]

Another quick search yields this - microsoft/vscode#90542
Which is closed for they think it is extensions.
Indeed, without any extensions it does not seem to occur. I have only one extension - Powershell.

[rjmholt]

Do you have format on save enabled?

[MarkKharitonov]

Yes Le jeu. 12 mars 2020 à 22:25, Robert Holt <[email protected]> a écrit :

…

Do you have format on save enabled? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2555 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADXSQDBPGB4ZWBR3XXCKCLRHGKSHANCNFSM4LGYV35A> .

-- Be well and prosper. ============================== "There are two kinds of people.Those whose guns are loaded and those who dig." ("The good, the bad and the ugly") So let us drink for our guns always be loaded.

[rjmholt]

My theory here is that:

• The Save Participants dialogue represents a VSCode functionality that runs the formatter on save
• It's waiting on the PowerShell extension to format something
• For some reason, that formatting run is hanging

We haven't been able to reproduce this error yet, but if we can, that will make this much easier to fix

[SydneyhSmith]

It would also be great if you could provide the payload logs, information for how to do that is here:
https://github.com/PowerShell/vscode-powershell/blob/master/docs/troubleshooting.md#provide-language-server-protocol-payload-logs

[MarkKharitonov]

@SydneyhSmith I do not use the preview version, so according to that link I cannot provide the payload logs:

NOTE: This currently only applies to the PowerShell Preview extension and only if you have version 2019.11.0 or higher.

Hmm, interesting that you cannot reproduce it. For me it reproduces right away. On the contrary, I cannot get rid of it. Had to downgrade the plugin version to the last of 2019. Still happens but more rarely.

I am open to demonstrate it live, if anyone wishes to send me a zoom meeting or anything like that.

[rjmholt]

I do not use the preview version, so according to that link I cannot provide the payload logs:

Ah the docs are out of date -- the stable extension will have these now

[bjbr-dev]

This is happening to me very frequently - what can I do next time it happens to help diagnose it?

[MarkKharitonov]

My advise - do not fight it, just downgrade the plugin to 2019.12.0. My empirical tests showed that this is the last version that allows to work sanely. I, personally, do not plan to upgrade until reports like this stop to appear.

[TylerLeonhardt]

You know what, I think this is a duplicate of this issue:

#2627 (comment)

Can you all try the build there and let me know how it goes?

[SydneyhSmith]

We recently published an update to our preview extension which has addressed a number of underlying architectural issues, would you mind giving it a try and letting us know if you are still hitting this issue?

[ghost]

This issue was closed automatically as repro info was indicated as needed, but there has been no activity in over a week. Please feel free to reopen with any available information!